Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pillow dependency with filetype #1847

Closed
wants to merge 2 commits into from

Conversation

cilki
Copy link

@cilki cilki commented Mar 31, 2024

Fixes #1801

Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned by the current maintained state of filetype but it appears that for images at least we should be fine. I am concerned that we don't have a test for this method yet, so if we can add one in that would give me confidence in using this package

@dimitarOnGithub
Copy link

@adehad just in case you've missed it, there's some general conversation about the use of this functionality going on in #1867 around this, seems like that was the PR that got traction, even if it was filed after this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dependency on pillow optional
3 participants