-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add required parameter field 'permissions' to my_permissions method #1472
add required parameter field 'permissions' to my_permissions method #1472
Conversation
this PR solves #879 |
afee965
to
ea5faa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, really appreciate you taking this on
I've made a separate branch to confirm that the tests run on the cloud instance (github has terrible secrets sharing to pull requests sorry), but happy for you to make further changes here and then merge this PR
tag class MyPermissionsCloudTests with marker allow_on_cloud Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
refactor: remove redundant check to skip cloud-run test Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
…ithub.com:rena2damas/jira into fix/pycontribs#879-my_permissions-needs-new-param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I'll get this running in #1473 to verify the tests are happy and then merge this PR
``permissions`` is a comma-separated value list of permission keys that is | ||
required in Jira Cloud. For possible and allowable permission values, see | ||
https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-permission-schemes/#built-in-permissions | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
As per Jira announcement:
In order to guarantee stability and performance of Jira Cloud, we are constantly reviewing Jira REST APIs to make sure their design enables and encourages good practices. Starting 1 February 2019, we will require that you provide the permissions query parameter in all requests to the Get my permissions resource.
Reference:
https://developer.atlassian.com/cloud/jira/platform/change-notice-get-my-permissions-requires-permissions-query-parameter/