Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required parameter field 'permissions' to my_permissions method #1472

Merged

Conversation

codectl
Copy link
Contributor

@codectl codectl commented Aug 23, 2022

As per Jira announcement:

In order to guarantee stability and performance of Jira Cloud, we are constantly reviewing Jira REST APIs to make sure their design enables and encourages good practices. Starting 1 February 2019, we will require that you provide the permissions query parameter in all requests to the Get my permissions resource.

Reference:
https://developer.atlassian.com/cloud/jira/platform/change-notice-get-my-permissions-requires-permissions-query-parameter/

@github-actions github-actions bot added the bug label Aug 23, 2022
@codectl codectl changed the title fix: add required parameter field 'permissions' to my_permissions method add required parameter field 'permissions' to my_permissions method Aug 23, 2022
@codectl
Copy link
Contributor Author

codectl commented Aug 23, 2022

this PR solves #879

@codectl codectl force-pushed the fix/#879-my_permissions-needs-new-param branch from afee965 to ea5faa9 Compare August 23, 2022 17:05
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, really appreciate you taking this on

I've made a separate branch to confirm that the tests run on the cloud instance (github has terrible secrets sharing to pull requests sorry), but happy for you to make further changes here and then merge this PR

tests/tests.py Outdated Show resolved Hide resolved
tests/tests.py Show resolved Hide resolved
jira/client.py Show resolved Hide resolved
codectl and others added 7 commits August 23, 2022 22:45
tag class MyPermissionsCloudTests with marker allow_on_cloud

Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
refactor: remove redundant check to skip cloud-run test

Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
…ithub.com:rena2damas/jira into fix/pycontribs#879-my_permissions-needs-new-param
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I'll get this running in #1473 to verify the tests are happy and then merge this PR

Comment on lines +2637 to +2640
``permissions`` is a comma-separated value list of permission keys that is
required in Jira Cloud. For possible and allowable permission values, see
https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-permission-schemes/#built-in-permissions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@adehad adehad linked an issue Aug 24, 2022 that may be closed by this pull request
@adehad adehad merged commit 968d983 into pycontribs:main Aug 24, 2022
@codectl codectl deleted the fix/#879-my_permissions-needs-new-param branch August 24, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIRA.my_permissions() needs a new required permissions parameter
2 participants