Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a case for search_assignable_users_for_issues where username an… #1401

Closed
wants to merge 1 commit into from

Conversation

niteshthakur
Copy link

This change fixes an issue where username and query arguments are not passed for method search_assignable_users_for_issues

@github-actions github-actions bot added the bug label Jun 15, 2022
@niteshthakur niteshthakur marked this pull request as draft June 15, 2022 16:18
@niteshthakur
Copy link
Author

need to remove check if not username and not query:

@studioj
Copy link
Collaborator

studioj commented Jun 24, 2022

looks legit , could you add a test which validates this?

@adehad
Copy link
Contributor

adehad commented Jun 26, 2022

need to remove check if not username and not query:

We still need this, this is what provides a useful error message to the user.

Technically this is also fixed by the changes in: #1394 - where this check is moved to before the arguments are used

@adehad
Copy link
Contributor

adehad commented Jun 28, 2022

Closing as #1394 is now merged.

@niteshthakur if you still have this problem do let me know and we can reopen this PR or create a new PR to address this

@adehad adehad closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants