-
-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated jira.search_issues
default behaviour to include all fields
#1360
updated jira.search_issues
default behaviour to include all fields
#1360
Conversation
The `jira.search_issues` documentation states that when nothing is passed to the field parameter, all fields are returned. https://jira.readthedocs.io/api.html?highlight=search_issues#jira.client.JIRA.search_issues The "*all" has been set as the default field parameter to achieve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, let's get some tests in!
@Yusuf-TJ Let's re-use this same pull request, easier to keep track of review comments and whether they have been addressed or not. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few minor changes, but really like the test cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
jira.search_issues
default behaviourjira.search_issues
default behaviour to include all fields
The
jira.search_issues
documentation states that when nothing is passed to the field parameter, all fields are returned.https://jira.readthedocs.io/api.html?highlight=search_issues#jira.client.JIRA.search_issues
The "*all" has been set as the default field parameter to achieve this.
Same fix as #1354
Resolves #1240