Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid printing parsed json response #1246

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Avoid printing parsed json response #1246

merged 4 commits into from
Nov 29, 2021

Conversation

studioj
Copy link
Collaborator

@studioj studioj commented Nov 27, 2021 •
edited
Loading

fixes #1243

Also included a few small refactorings for code readability

@studioj studioj requested a review from adehad November 28, 2021 00:20
adehad
adehad approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ssbarnea ssbarnea changed the title fix for #1243 dont print r_json Avoid printing parsed json response Nov 29, 2021
@ssbarnea ssbarnea merged commit bf8d6cb into main Nov 29, 2021
@ssbarnea ssbarnea deleted the dont_print_r_json branch November 29, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't print parsed json response in service_desks()
3 participants
@studioj @ssbarnea @adehad