Fix JWT QSH generation for urls with repeated parameters #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add test for QshGenerator.generate_qsh
adehad
requested changes
Sep 23, 2021
|
Ah lint failing might be because we've updated our lint steps, try merging in master before running |
adehad
approved these changes
Sep 26, 2021
|
Thank you for your contribution ! |
svermeulen
pushed a commit
to svermeulen/jira
that referenced
this pull request
Oct 31, 2021
…1157) * Fix QshGenerator to combine repeated query string parameters into csv * add test for QshGenerator.generate_qsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where e.g.
search_issues(jql, fields=["field1", "field2"])would fail to authenticate because the generated qsh was invalid. The url requested is like...&fields=field1&fields=field2&....These repeated parameters must be combined into a single csv parameter according to https://developer.atlassian.com/cloud/jira/platform/understanding-jwt-for-connect-apps/#qsh when computing the QSH for JWT auth.