Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'username' parameter to 'query' for GDPR compliance #1119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change 'username' parameter to 'query' for GDPR compliance #1119

wants to merge 2 commits into from

Conversation

mkalinowski-fandom
Copy link

No description provided.

adehad
adehad requested changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to #1117 for how best to do this, so we support both Jira Cloud and Jira Server.

Feel free to reach out if anything is unclear.

Thanks

@studioj
Copy link
Collaborator

studioj commented Aug 28, 2021

@mkalinowski-fandom does #1117 solve the need for your PR, if so please close it.
thank you for wanting to contribute!

@adehad
Copy link
Contributor

adehad commented Sep 18, 2021

@studioj Sorry I was suggesting that #1117 would be a good example to see how to change a function to support both "username" and "query" arguments so we can support both Server and Cloud.

This particular merge request fixes the compatibility for a different function than the one changed in #1117

@studioj studioj added the stale Ticket that is likely to go nowhere and that will be closed soon label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
stale Ticket that is likely to go nowhere and that will be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkalinowski-fandom @studioj @adehad