Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding version to documentation to help out on #1016 #1039

Merged
merged 3 commits into from
May 15, 2021
Merged

adding version to documentation to help out on #1016 #1039

merged 3 commits into from
May 15, 2021

Conversation

studioj
Copy link
Collaborator

@studioj studioj commented May 13, 2021

#1016 suggested a rename version feature.
although not implemented yet it seems possible with the Version.update functionality

This addition to the documentation will at least make it more clear where to look for such solutions

@studioj studioj added the docs label May 13, 2021
@studioj
Copy link
Collaborator Author

studioj commented May 13, 2021

i see @adehad is also fixing this (halfly) with this PR https://github.com/pycontribs/jira/pull/1023/files
although my implementation doesn't follow his changed doc generation

@studioj studioj force-pushed the version_resource_is_not_in_documenation branch from 2a69f50 to 32f03a9 Compare May 13, 2021 16:30
@studioj studioj mentioned this pull request May 13, 2021
Merged
7 tasks
adehad
adehad requested changes May 13, 2021
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you say I've made some changes in my branch too, I'm happy for this to be merged first, as my PR is a bit large and probably will take a while to get approved. Until then I think let's get this merged, only a few minor comments from me.

jira/resources.py Outdated Show resolved Hide resolved
jira/resources.py Outdated Show resolved Hide resolved
jira/resources.py Outdated Show resolved Hide resolved
@studioj studioj force-pushed the version_resource_is_not_in_documenation branch from 32f03a9 to f81d595 Compare May 13, 2021 21:41
adehad
adehad approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@ssbarnea ssbarnea merged commit e9e0d60 into master May 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the version_resource_is_not_in_documenation branch May 15, 2021 12:09
@ssbarnea ssbarnea added the bug label Oct 4, 2021
svermeulen pushed a commit to svermeulen/jira that referenced this pull request Oct 31, 2021
@studioj @svermeulen
adding version to documentation to help out on pycontribs#1016 (pycon…
54aeb0a 
…tribs#1039)

* adding version to documentation to help out on pycontribs#1016

* updating param name from **args to **kwargs and adding some test coverage for it

* adding an example in the method documentation

Co-authored-by: Neefs, Jef <jef.neefs@barco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@studioj @ssbarnea @adehad