Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on OpenSSL 1.1.0 with travis. Fixes #524 #526

Merged
merged 19 commits into from
Sep 24, 2016
Merged

Conversation

alex
Copy link
Member

@alex alex commented Sep 5, 2016

No description provided.

@mention-bot
Copy link

@alex, thanks for your PR! By analyzing the annotation information on this pull request, we identified @reaperhulk, @hynek and @lvh to be potential reviewers

@reaperhulk
Copy link
Member

LGTM, although tests will fail until we merge the fixes we need. I'm inclined to merge this so that we can quickly fix the 1.1.0 bugs though.

@alex
Copy link
Member Author

alex commented Sep 5, 2016

Unless there's a large volume of them, I'm content to simply fix them on this branch. If they are aplenty I'll add this to the allowed_failures section

@alex
Copy link
Member Author

alex commented Sep 5, 2016

Found an OpenSSL bug in the process of working on this openssl/openssl#1537

@alex
Copy link
Member Author

alex commented Sep 10, 2016

Ok, another bug: openssl/openssl#1563

@hynek
Copy link
Contributor

hynek commented Sep 10, 2016

pyOpenSSL is actually being useful!

@alex
Copy link
Member Author

alex commented Sep 10, 2016

There are a few skips, but tests are passing on 1.1.0! Next steps:

  • Send PRs cherry-picking some of the easy stuff here over to master
  • Get the tests passing on 1.0.1 again (oops)
  • Figure out what to do about the skips

@codecov-io
Copy link

codecov-io commented Sep 23, 2016

Current coverage is 95.61% (diff: 100%)

Merging #526 into master will increase coverage by 0.06%

@@             master       #526   diff @@
==========================================
  Files            16         16          
  Lines          5598       5616    +18   
  Methods           0          0          
  Messages          0          0          
  Branches        405        409     +4   
==========================================
+ Hits           5349       5370    +21   
+ Misses          174        172     -2   
+ Partials         75         74     -1   

Powered by Codecov. Last update 9f9113a...3d19404

@alex alex mentioned this pull request Sep 23, 2016
Copy link
Contributor

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work Alex!

@hynek hynek merged commit 5af32d0 into pyca:master Sep 24, 2016
@alex alex deleted the openssl-1.1.0 branch September 24, 2016 13:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants