-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on OpenSSL 1.1.0 with travis. Fixes #524 #526
Conversation
@alex, thanks for your PR! By analyzing the annotation information on this pull request, we identified @reaperhulk, @hynek and @lvh to be potential reviewers |
LGTM, although tests will fail until we merge the fixes we need. I'm inclined to merge this so that we can quickly fix the 1.1.0 bugs though. |
Unless there's a large volume of them, I'm content to simply fix them on this branch. If they are aplenty I'll add this to the allowed_failures section |
Found an OpenSSL bug in the process of working on this openssl/openssl#1537 |
Ok, another bug: openssl/openssl#1563 |
pyOpenSSL is actually being useful! |
There are a few skips, but tests are passing on 1.1.0! Next steps:
|
Current coverage is 95.61% (diff: 100%)@@ master #526 diff @@
==========================================
Files 16 16
Lines 5598 5616 +18
Methods 0 0
Messages 0 0
Branches 405 409 +4
==========================================
+ Hits 5349 5370 +21
+ Misses 174 172 -2
+ Partials 75 74 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work Alex!
No description provided.