-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to codecov.io from coveralls #1388
Conversation
Is there any reason why we couldn't install codecov in our OS X branches for Travis so we can submit there as well? |
Can one of the admins verify this patch? |
ok to test |
I didn't disable OSX support in this PR, I disabled it in my fork temporarily since running on OSX costs money (or so I thought?). |
Let me ask a less stupid question -- was it disabled in your test because it has to be enabled explicitly by Travis? |
Ah, got it. It doesn't cost money but enabling it is on a per repository basis so it wouldn't have run on your fork, correct. |
Will it leave a comment here after this run? |
You can enable/disable that when logged in and viewing the dashboard I think |
Current Coverage via 8491420 is
|
Test PASSed. |
It looks like codecov doesn't support merging coverage reports together yet. For now I'm going to close this issue, if/when they add support leave a comment adn we can reopen -- otherwise the service looks very nifty. |
Coveralls doesn't care at all about branch coverage reporting, it just cares about lines (lemurheavy/coveralls-public#31). We are already choosing to generate branch coverage stats, but coveralls just ignores them. codecov.io incorporates branch data into their test coverage reporting. You can see an example here using pyca/cryptography (keep in mind I disabled osx support when this ran).