Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to codecov.io from coveralls #1388

Closed
wants to merge 1 commit into from
Closed

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Oct 8, 2014

Coveralls doesn't care at all about branch coverage reporting, it just cares about lines (lemurheavy/coveralls-public#31). We are already choosing to generate branch coverage stats, but coveralls just ignores them. codecov.io incorporates branch data into their test coverage reporting. You can see an example here using pyca/cryptography (keep in mind I disabled osx support when this ran).

@reaperhulk
Copy link
Member

Is there any reason why we couldn't install codecov in our OS X branches for Travis so we can submit there as well?

@jenkins-cryptography
Copy link

Can one of the admins verify this patch?

@alex
Copy link
Member

alex commented Oct 8, 2014

ok to test

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2014

I didn't disable OSX support in this PR, I disabled it in my fork temporarily since running on OSX costs money (or so I thought?).

@reaperhulk
Copy link
Member

Let me ask a less stupid question -- was it disabled in your test because it has to be enabled explicitly by Travis?

@reaperhulk
Copy link
Member

Ah, got it. It doesn't cost money but enabling it is on a per repository basis so it wouldn't have run on your fork, correct.

@alex
Copy link
Member

alex commented Oct 8, 2014

Will it leave a comment here after this run?

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2014

You can enable/disable that when logged in and viewing the dashboard I think

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Oct 8, 2014

screen shot 2014-10-08 at 12 28 23 am

@codecov-io
Copy link

Current Coverage via 8491420 is 89.62%

Merging master into master will change coverage by +0.10%


Compare master...master

@@            master   master   diff @@
=======================================
  Files          140      140       
  Stmts         7092     7092       
  Branches       851      851       
=======================================
- Hit           7050     6356   -694
- Partial         42       74    +32
- Missed           0      662   +662

@jenkins-cryptography
Copy link

Test PASSed.
Refer to this link for build results: https://jenkins.cryptography.io/job/cryptography-pr-experimental/2362/

@alex
Copy link
Member

alex commented Oct 8, 2014

It looks like codecov doesn't support merging coverage reports together yet. For now I'm going to close this issue, if/when they add support leave a comment adn we can reopen -- otherwise the service looks very nifty.

@alex alex closed this Oct 8, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

5 participants