Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #60 and #61 #75

Merged
merged 2 commits into from
Nov 18, 2016
Merged

Fix for #60 and #61 #75

merged 2 commits into from
Nov 18, 2016

Conversation

tokejepsen
Copy link
Member

Problem was as expected where if an Instance or Plugin had failed, and then succeeded, the failed state got overwritten with the newest succceded state.
Solution was to never go back from a failed state, and implemented by only updating the failed state if the Instance/Plugin hasn't already failed.

@tokejepsen
Copy link
Member Author

@mottosso when you have time, could take a look at this?

@mottosso
Copy link
Member

Sorry, I did have a look at this, but then somehow forgot about commenting.

Looks good to me, could you bump the version as well?

@tokejepsen
Copy link
Member Author

Done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants