Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing "failed" actions on plugins with warnings instead of errors #116

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix missing "failed" actions on plugins with warnings instead of errors #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pyblish_lite/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ def data(self, index, role):
for action in actions:
if action.on == "failed" and item._has_failed:
return True
if action.on == "warning" and item._has_warning:
return True
if action.on == "failedOrWarning" and (item._has_failed or item._has_warning):
return True
if action.on == "succeeded" and item._has_succeeded:
return True
if action.on == "processed" and item._has_processed:
Expand All @@ -247,6 +251,10 @@ def data(self, index, role):
for action in actions[:]:
if action.on == "failed" and not item._has_failed:
actions.remove(action)
if action.on == "warning" and not item._has_warning:
actions.remove(action)
if action.on == "failedOrWarning" and not (item._has_failed or item._has_warning):
actions.remove(action)
if action.on == "succeeded" and not item._has_succeeded:
actions.remove(action)
if action.on == "processed" and not item._has_processed:
Expand Down
2 changes: 1 addition & 1 deletion pyblish_lite/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
VERSION_MAJOR = 0
VERSION_MINOR = 8
VERSION_PATCH = 8
VERSION_BETA = "b2"
VERSION_BETA = "b3"

version_info = (VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH, VERSION_BETA)
version = '%i.%i.%i%s' % version_info
Expand Down