Fix warning color only displayed if last instance has a warning #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find @jboisvertrodeofx, this looks good to me. The latest release is currently a pre-release due to some fixes to the processing behavior (#113) so for at least a few more days whilst it is being tested I'll continue to release Lite as pre-release. If you update the version to this PR (I didn't have access to do so myself) to |
|
@mottosso thanks for the quick reply! I've set the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug where the warning color is not displayed next to plugins in which a warning was logged for some instances but not the last executed one.
When logging a warning in an
InstancePlugin, the UI reacts by coloring the little square as orange next to the plugin's label. However, this behavior only works if the last instance to be executed has a warning logged. If there are 3 instances and a warning is logged only for the first instance, then the little square will be displayed as green, as if there was no warning at all.The fix is to simply check in the model's
hasWarningdata to see if a warning was previously set, and if so, then keep it that way.