Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Icons #53

Closed
tokejepsen opened this issue Aug 12, 2016 · 6 comments
Closed

Action Icons #53

tokejepsen opened this issue Aug 12, 2016 · 6 comments

Comments

@tokejepsen
Copy link
Member

Goal

To mirror the behavior from pyblish-qml.

Motivation

Easier to discover and find plugins that have actions associated with them.

Implementation

The behavior should be the exact same as in pyblish-qml; pyblish/pyblish-qml#166

@tokejepsen
Copy link
Member Author

It looks like pyblish-lite doesn't differentiate between processing a plugin and processing an action. This results in the checkbox being colored by the action depending on success/failure.

This means we could leave out the coloring of the action icon, and just display it.

@tokejepsen
Copy link
Member Author

Actually this doesn't work out very well. When an plugin is failed and the checkbox is red, running an action that fails as well results in nothing happening in the UI, leaving the user thinking that nothing has happened at all.

@mottosso
Copy link
Member

mottosso commented Aug 12, 2016

Shouldn't be difficult giving actions a unique property for use in the delegate.

It'd take another member in the model, and something to draw that member in the delegate.

This is where an action is triggered, this could also be where this member is updated.

@tokejepsen
Copy link
Member Author

This is where an action is triggered, this could also be where this member is updated.

I don't see any direct interaction between the model and the controller. Should I not update the model in the controller?

@tokejepsen
Copy link
Member Author

Actually I think I have something that works, and it emulating the plugin processing.

@tokejepsen tokejepsen mentioned this issue Aug 15, 2016
@tokejepsen
Copy link
Member Author

Implemented with #55

tokejepsen pushed a commit to tokejepsen/pyblish-lite that referenced this issue May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants