Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traceback line without space #362

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Traceback line without space #362

merged 2 commits into from
Mar 2, 2020

Conversation

iLLiCiTiT
Copy link
Contributor

Cosmetic change:

  • added missing space to replacement string in traceback formatting

@mottosso
Copy link
Member

mottosso commented Mar 2, 2020

Nitpick, but would it maybe make more sense to remove the additional space from the source string?

@iLLiCiTiT
Copy link
Contributor Author

Now when you talk about it, I think so too :) will change

@mottosso mottosso merged commit acf97ef into pyblish:master Mar 2, 2020
@mottosso
Copy link
Member

mottosso commented Mar 2, 2020

Looks good to me, thanks. Make a new PR with a version increment if you want it released immediately.

@mottosso mottosso mentioned this pull request Mar 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mottosso