-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[smart_holder] Remove obsolete detail::type_info::default_holder
member.
#5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_INTERNALS_VERSION 7
Example error message (🐍 3.11 • ubuntu-latest • x64, GNU 13.3.0): ``` include/pybind11/detail/value_and_holder.h:56:52: error: ‘uint8_t’ is not a member of ‘std’; did you mean ‘wint_t’? 56 | inst->nonsimple.status[index] &= (std::uint8_t) ~instance::status_holder_constructed; | ^~~~~~~ ```
…nfo->default_holder. BUILDS BUT 2 TESTS ARE FAILING.
…ique_ptr` Intentionally not changing error messages, because this would result in a significantly bigger change.
…a follow-on PR that actually changes the internals.
…ges the internals).
@rhaschke for visibility. — I hope this will bring an end to the smart_holder / |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core change under this PR is (include/pybind11/detail/internals.h):
This PR
Rationale:
default_holder
member requires aPYBIND11_INTERNALS_VERSION
bump. To minimize bumps on master, this is done before merging smart_holder into master.// SMART_HOLDER_BAKEIN_FOLLOW_ON: Refine holder compatibility checks.
comments are added here, so that it will be easy to pin-point where we want to produce better error messages.Suggested changelog entry: