Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store nuisance models and scores #433

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Store nuisance models and scores #433

merged 2 commits into from
Mar 19, 2021

Conversation

heimengqi
Copy link
Contributor

  • store nuisance models and scores for each mc iteration, return as a nested list
  • adapt the final stage score function by averaging all the nuisances from each iteration and each split.

kbattocchi
kbattocchi approved these changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think list comprehensions would look cleaner than the current approach to building the nested lists.

@heimengqi heimengqi merged commit 7005b24 into master Mar 19, 2021
@heimengqi heimengqi deleted the mehei/store_nuisances branch March 19, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

@vsyrgkanis vsyrgkanis Awaiting requested review from vsyrgkanis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heimengqi @kbattocchi