Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new extras #413

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Create new extras #413

merged 1 commit into from
Feb 20, 2021

Conversation

kbattocchi
Copy link
Collaborator

This PR creates new tf and interpret extras, which install tensorflow and keras for tf and matplotlib and graphviz for interpret, as well as an all extra which installs all of those. This allows us to remove some heavy dependencies from the main package which are only used in a very small number of places (DeepIV is the only place keras and tensorflow are used, and the CATE tree interpreters are the only place that matplotlib and graphviz are used).

@kbattocchi kbattocchi force-pushed the kebatt/makeExtras branch 4 times, most recently from e1b7464 to c6044c5 Compare February 19, 2021 21:43
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kbattocchi kbattocchi force-pushed the kebatt/makeExtras branch 2 times, most recently from 4a621a8 to b1804e4 Compare February 20, 2021 01:49
@kbattocchi kbattocchi enabled auto-merge (rebase) February 20, 2021 09:14
@kbattocchi kbattocchi merged commit 3aeca47 into master Feb 20, 2021
@kbattocchi kbattocchi deleted the kebatt/makeExtras branch February 20, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants