Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RScorer class for causal model selection #361

Merged
merged 11 commits into from
Jan 12, 2021
Merged

RScorer class for causal model selection #361

merged 11 commits into from
Jan 12, 2021

Conversation

vsyrgkanis
Copy link
Collaborator

No description provided.

@vsyrgkanis vsyrgkanis requested a review from kbattocchi January 3, 2021 22:57
@vsyrgkanis vsyrgkanis changed the title Vasilis/rscorer RScorer class for causal model selection Jan 6, 2021
kbattocchi
kbattocchi requested changes Jan 11, 2021
View reviewed changes
econml/score/ensemble_cate.py Show resolved Hide resolved
econml/score/ensemble_cate.py Show resolved Hide resolved
econml/score/ensemble_cate.py Show resolved Hide resolved
econml/score/ensemble_cate.py Show resolved Hide resolved
econml/score/__init__.py Show resolved Hide resolved
econml/score/rscorer.py Outdated Show resolved Hide resolved
econml/score/rscorer.py Outdated Show resolved Hide resolved
econml/tests/test_rscorer.py Outdated Show resolved Hide resolved
@vasilismsr
fixed review feedback
544a090 
fixed glossary reference CV
kbattocchi
kbattocchi approved these changes Jan 11, 2021
View reviewed changes
econml/score/ensemble_cate.py Show resolved Hide resolved
heimengqi
heimengqi suggested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left couple of comments, I think the major issue is the score function needs to be updated to incorporate monte carlo simulation?

econml/score/rscorer.py Show resolved Hide resolved
econml/score/rscorer.py Show resolved Hide resolved
econml/score/rscorer.py Show resolved Hide resolved
notebooks/Causal Model Selection with the RScorer.ipynb Show resolved Hide resolved
@vasilismsr
added readme on model selection
a7edb6f 
readme alignments

linting
heimengqi
heimengqi approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vsyrgkanis vsyrgkanis merged commit b5c25cc into master Jan 12, 2021
@vsyrgkanis vsyrgkanis deleted the vasilis/rscorer branch January 12, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

@heimengqi heimengqi heimengqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsyrgkanis @kbattocchi @heimengqi @vasilismsr