Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasilis/cate interpreters #177

Merged
merged 112 commits into from
Dec 7, 2019
Merged

Vasilis/cate interpreters #177

merged 112 commits into from
Dec 7, 2019

Conversation

vasilismsr
Copy link
Contributor

Intepretation of CATE via Trees

vasilismsr and others added 30 commits November 5, 2019 20:36
…had T0 and T1 as non keyword arguments. They should be. A bug fix in treatment expansion mixin revealed this mistake.
…ive tests for api of drlearner and linear_drlearner. Fixed small bug in marginal_effect_interval of linearcateestimator.
…er. Bug from reverting back to coef_ and intercept_ in StatsModelsInference.
…or metalearners to call the new doubly robust learner. Fixed bug in test_drlearner
…y support a specific subset of covariance types
@kbattocchi kbattocchi force-pushed the vasilis/cate_interpreters branch from bb657e1 to 49d43ec Compare December 5, 2019 14:56
@kbattocchi
Copy link
Collaborator

@vasilismsr I've heavily refactored the tree exporting logic. Can you take a look and verify you're happy with the general shape of things (maybe just look at the changes from my commits)?

@kbattocchi kbattocchi marked this pull request as ready for review December 5, 2019 20:35
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly seems good to me!

econml/cate_interpreter.py Outdated Show resolved Hide resolved
@kbattocchi kbattocchi mentioned this pull request Dec 6, 2019
@kbattocchi kbattocchi requested a review from heimengqi December 6, 2019 20:55
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kbattocchi kbattocchi force-pushed the vasilis/cate_interpreters branch from 3176c62 to 11766cb Compare December 7, 2019 05:44
@kbattocchi kbattocchi merged commit dbcbae5 into master Dec 7, 2019
@kbattocchi kbattocchi deleted the vasilis/cate_interpreters branch December 7, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants