-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default bump strategy for dependabot #585
Conversation
Default strategy works okay on my repositories and currently dependabot doesn't change `pyproject.toml` at all, I hope this PR will fix this
I thought the reason we used
I don't necessarily want to force library users to use the newest possible version, as other libraries that specify the same dependency might do so in a more limiting manner (like for example |
I only see dev dependency groups being updated. Would this influence the main group of dependencies? Should we look at what dependabot generates and make changes after? |
Dependabot updates all dependencies, both development and main ones. It's just that we don't have very many main dependencies, and so the updates you see most often are for the development deps, which there's a lot of. |
Does Dependabot allow different configuration overrides? If it does, we could place an override for any explicitly called-out development (or runtime?) dependencies. I'm also okay with ignoring the runtime updates when they pop up in PRs, but one could accidentally slip by since I tend to merge those without much thought if all the checks are passing. Runtime dependency updates would only take effect during the next release, giving us time to revert an accidental update. Should we experiment with this new strategy and then react based on Dependabot's new behavior? Edit: Would this work for us? Or would we still need multiple "pip" configurations to allow these to update-when-necessary? ignore:
- dependency-name: "asyncio-dgram"
update-types: ["version-update:semver-minor"]
- dependency-name: "dnspython"
update-types: ["version-update:semver-minor"] |
We should be able to do even better than that, we can just have 2 pip configurations use |
The reason was described in #522, it was done to workaround annoying dependabot's bug, which I can't reproduce now.
We should then use I just find it confusing, when dependency's version is different in
This is why caret dependency specification exist in poetry. It just allows any semver-compatible version.
It should work, I use something same in my other projects. |
(can't re-request review from @ItsDrike) |
…t-strategy # Conflicts: # poetry.lock # pyproject.toml
Default strategy works okay on my repositories and currently dependabot doesn't change
pyproject.toml
at all, I hope this PR will fix this.Strategy was introduced in #522.