-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coverage comment #211
Conversation
End-to-end public repo |
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)coverage_comment/badge.py
coverage_comment/coverage.py
coverage_comment/diff_grouper.py
coverage_comment/files.py
coverage_comment/groups.py
coverage_comment/main.py
coverage_comment/settings.py
coverage_comment/template.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just testing reviews, don't mind me.
7438f63
to
0d0f0a1
Compare
0d0f0a1
to
1afb389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments ! We're definitely going in the right direction, and approaching the goal !
d2c3ab7
to
39ae4ea
Compare
c300fa0
to
747294b
Compare
Tests are all over the place, but we're generating comments that start to look as expected. |
eea7cba
to
fb8f291
Compare
…_coverage objects
fb8f291
to
0bf474d
Compare
Fixes #189 and using comment designed in #235
This PR tries to make the coverage comment more readable and practical by:
This should be merged after #184, as coverage in subdirectories is something that needs to be considered when generating urls.