forked from tektoncd/pipeline
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0089] - Phase 2 Signed TaskRun #17
Open
pxp928
wants to merge
2
commits into
spire-phase-1
Choose a base branch
from
spire-phase-2
base: spire-phase-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxp928
changed the title
[TEP-0089] - Implement Non-falsifiable provenance support
[TEP-0089] - Phase 2 Signed TaskRun
May 3, 2022
pxp928
force-pushed
the
spire-phase-1
branch
3 times, most recently
from
May 10, 2022 14:03
00f73a0
to
b55a667
Compare
pxp928
force-pushed
the
spire-phase-1
branch
3 times, most recently
from
May 31, 2022 19:35
e3e93c2
to
aae23e4
Compare
pxp928
force-pushed
the
spire-phase-1
branch
5 times, most recently
from
June 25, 2022 22:03
289b644
to
792abd4
Compare
pxp928
force-pushed
the
spire-phase-1
branch
4 times, most recently
from
July 29, 2022 00:32
7339bef
to
13ed6ef
Compare
pxp928
force-pushed
the
spire-phase-2
branch
2 times, most recently
from
July 29, 2022 01:17
9e43f54
to
e3d8140
Compare
pxp928
force-pushed
the
spire-phase-2
branch
5 times, most recently
from
July 29, 2022 01:39
4ee4296
to
260f5e2
Compare
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pxp928 parth.psu@gmail.com
Changes
Authors - @pxp928 and @lumjjb
In association with TEP-0089: Non-falsifiable provenance support
This PR is the implementation of Phase 2 of the TEP-0089: Non-falsifiable provenance support
Phase 2
Continuation of phase 1 of TEP-0089. This PR adds signed TaskRuns by adding an annotation to that TaskRun Status. This only allows for changes from the pipeline controller to be valid. All others interactions will be marked as not valid and fail the spire verification.
Once Tekton Pipeline completes, Chains will run to verify both the TaskRun Results and the TaskRun are validated by Spire. If they do not pass the check, Chains will not sign the TaskRun.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
Please provide feedback and improvements!