Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Pwabuilder issue 824 #404

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Pwabuilder issue 824 #404

merged 4 commits into from
Aug 31, 2020

Conversation

lee-leonardo
Copy link
Contributor

Fixes #

pwa-builder/PWABuilder#824

PR Type

  • Bugfix
  • Accessibility

Describe the current behavior?

Focus state was on the component, not the button itself, this readds the focus state to the button.

Describe the new behavior?

Focus

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Aug 29, 2020

Thanks lee-leonardo for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned davrous Aug 29, 2020
@JudahGabriel JudahGabriel merged commit d5fabc8 into master Aug 31, 2020
@JudahGabriel JudahGabriel deleted the pwabuilder_issue824 branch August 31, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants