Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

chore(): karma does not fail when global thresholds not met #29

Merged
merged 1 commit into from
Nov 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coverage/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ <h1>
</div><!-- /wrapper -->
<div class='footer quiet pad2 space-top1 center small'>
Code coverage
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Thu Nov 14 2019 10:54:56 GMT-0800 (Pacific Standard Time)
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Thu Nov 14 2019 11:13:41 GMT-0800 (Pacific Standard Time)
</div>
</div>
<script src="prettify.js"></script>
Expand Down
8 changes: 7 additions & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = config => {
plugins: [
// load plugin
require.resolve('@open-wc/karma-esm'),

// fallback: resolve any karma- plugins
'karma-*',
],
Expand All @@ -28,6 +28,12 @@ module.exports = config => {
// if you are using 'bare module imports' you will need this option
nodeResolve: true,
},

coverageIstanbulReporter: {
thresholds: {
emitWarning: true
}
}
}),
);
return config;
Expand Down
214 changes: 214 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"deepmerge": "^4.2.2",
"es-dev-server": "^1.18.4",
"karma": "^4.4.1",
"karma-threshold-reporter": "^0.1.15",
"rollup": "^1.26.0",
"rollup-plugin-babel-minify": "^9.1.1",
"rollup-plugin-minify-html-literals": "^1.2.2",
Expand Down