Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

fix overflow scroll and cut off text #114

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

hipstersmoothie
Copy link
Contributor

Fixes #112

PR Type

Bugfix

Describe the current behavior?

Screen Shot 2020-01-05 at 8 30 31 PM

Describe the new behavior?

The modal now has a dynamic height and is scrollable.

Screen Shot 2020-01-05 at 8 35 56 PM

Screen Shot 2020-01-05 at 8 36 01 PM

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Jan 6, 2020

Thanks for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@jgw96 jgw96 merged commit 0f771f6 into pwa-builder:master Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow with enough content or certain screen
2 participants