-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Tooltips are always shown in light mode, even in dark mode. #2348
base: main
Are you sure you want to change the base?
Conversation
funny branch name 😂 |
Have we considered fixing this upstream instead of in pvlib? |
That would be nuts, although it does not seem easy since each theme (e.g. pydata-sphinx-theme) provides it's own way of specifying the theme colours (source comment). Anyways, they would surely welcome any PR in that regard. I wouldn't be able to do so, thou. So I propose mitigating this problem now this easy way and removing these changes in the future once it gets fixed (if so). |
@echedey-ls I see a mix of dark and light mode, is that expected? |
Idk, but I was sure I got this right in some previous commit. In any case, here it is again. Apologies for the mail inbox notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine for me now, nice job @echedey-ls
I know some people that would argue that's a health issue (me).
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.