Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to outdated tutorials #2009

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Remove link to outdated tutorials #2009

merged 5 commits into from
Apr 16, 2024

Conversation

AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The tutorials referenced have not been maintained for several years and should in my opinion not be referenced as a first place to start.

@cwhanse
Copy link
Member

cwhanse commented Apr 12, 2024

Perhaps I was hasty in approving - what in Intro Tutorials is out of date? We re-wrote it for v0.9 when Arrays were introduced, and later when Mount was introduced.

@echedey-ls
Copy link
Contributor

As a sidenote to the ongoing conversation, don't be confused like me by the tutorials referenced in contributing.rst - the IPython/Jupyter notebooks. I think those are the ones that really need to be excluded from any page.

@AdamRJensen
Copy link
Member Author

Perhaps I was hasty in approving - what in Intro Tutorials is out of date? We re-wrote it for v0.9 when Arrays were introduced, and later when Mount was introduced.

@cwhanse You are so right. As @echedey-ls pointed out, I removed the wrong tutorial link. The link that has now been removed is the link to the old notebook tutorials on the installation page. Sorry for the mix up.

@AdamRJensen AdamRJensen changed the title Remove link to outdate tutorials Remove link to outdated tutorials Apr 13, 2024
@echedey-ls
Copy link
Contributor

echedey-ls commented Apr 14, 2024

Thanks for confirming my suspicion. Few more references to the notebooks are in:

  • sphinx/source/contributing.rst, line 32
  • sphinx/source/index.rst, line 18
  • sphinx/source/user_guide/installation.rst, line 87

I think this PR's scope allows for a complete purge of these references if everyone agrees. At least the one in contributing.rst, no wonder why I started working on a notebook in my first PR here haha.

@cwhanse
Copy link
Member

cwhanse commented Apr 14, 2024

I agree with removing links to the jupyter notebooks.

@kandersolar kandersolar added this to the v0.10.5 milestone Apr 16, 2024
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@kandersolar kandersolar merged commit ba458bd into main Apr 16, 2024
28 of 29 checks passed
@kandersolar kandersolar deleted the AdamRJensen-patch-1 branch April 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants