Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove download badges from README #1941

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

There are currently two download badges on the pvlib python README page:
image

The first badge is from PyPi and the second from conda forge. Both badges show approximately the same number of downloads, but the first is per month and the second is totals - that seems inconsistent although I realize that they're different sources. I simply suggest to declutter the badge section and remove this downloads as they are dominated by automated tests downloading the packages and doesn't add any meaningful information/value (i.e., they say nothing about our actual user base).

There are already badges for both PyPi and conda forge at the top of the bad section in the "Latest release" section.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me.

Tangentially related: can we updated all the conda-forge links in the first row to use pvlib instead of pvlib-python? The latter is just for backwards compatibility, so better to direct people to the former.

@AdamRJensen AdamRJensen marked this pull request as ready for review January 2, 2024 13:09
@AdamRJensen AdamRJensen merged commit 009e913 into pvlib:main Jan 15, 2024
33 checks passed
@AdamRJensen AdamRJensen deleted the remove_download_badges branch January 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants