Update citation in pvlib readme #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CITATION.cff file should probably also be updated |
kandersolar
reviewed
Dec 22, 2023
There was a problem hiding this comment.
The CITATION.cff file should probably also be updated
We haven't got one, see #1322.
Also, as long as we're editing the README, can you fix the link in the "history and acknowledgement" section? I copy/pasted RST syntax instead of markdown by accident.
kandersolar
reviewed
Jan 2, 2024
cwhanse
approved these changes
Jan 12, 2024
|
@pvlib/pvlib-core Merging this tomorrow if no objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.A new paper concerning pvlib has been published in JOSS: https://doi.org/10.21105/joss.05994
Therefore, it seems fitting to update the recommended citation. I might make sense to keep a reference to the 2018 JOSS paper somewhere - ideas?