Compatibility with pandas 2.0.0 #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm impressed! |
|
This branch has no failures on the just-released 2.0.0rc1 as well. Their ETA for the actual release of pandas 2.0.0 is still "about two weeks". |
|
This is ready for review now that pandas 2.0.0 has been released. Note that wheels are available on PyPI, but the new version isn't yet available on conda, so the CI isn't currently using it for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Closes #xxxx- [ ] Tests added- [ ] Updates entries indocs/sphinx/source/referencefor API changes.- [ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).- [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.The first release candidate for pandas 2.0.0 was released yesterday: https://github.com/pandas-dev/pandas/releases/tag/v2.0.0rc0. It's available on PyPI with
pip install --pre pandas==2.0.0rc0.The list of changes is pretty extensive, but it seems like we escape nearly unscathed: it doesn't seem to break anything in pvlib itself and only causes one small issue in our tests. This PR fixes that test issue.
Since pvlib itself seems to be compatible, I suggest we wait to merge this PR until pandas 2.0.0 is officially released (anticipated in "a couple weeks") in case there are any other breaking changes made between now and then.