Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct infinite_sheds view factor from row to sky and ground; expose vf functions in bifacial.utils #1666

Merged
merged 27 commits into from
Jun 23, 2023
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f684623
correct view factor from row to sky and ground
mikofski Feb 15, 2023
ef346dd
update latex math in vf_row_gnd
mikofski Feb 15, 2023
510e8ad
revise vf_row_sky and test
Mar 22, 2023
fdc7a63
remake tests for vf_row_ground
cwhanse Mar 23, 2023
784a977
fix my mistakes
cwhanse Mar 23, 2023
c48b35c
fix row_ground_integ
cwhanse Mar 23, 2023
253bb89
new vf functions in utils
cwhanse Mar 24, 2023
2a9bff1
merge 0.9.5 upstream
cwhanse Mar 24, 2023
5837fd3
stickler
cwhanse Mar 24, 2023
3246196
use functions from utils
cwhanse Mar 24, 2023
a0451b7
documents
cwhanse Mar 24, 2023
a77dbb0
revise whatsnew
cwhanse Mar 24, 2023
09f3f86
add technical document
cwhanse Mar 24, 2023
e7b7d5f
doc edits
cwhanse Apr 3, 2023
fc6c7d9
fix conflicts
cwhanse May 15, 2023
df56b3a
Merge branch 'fix_vf_row_sky_gh1665' of https://github.com/mikofski/p…
cwhanse May 15, 2023
6a026ad
move fns to utils
cwhanse May 15, 2023
47bd4de
more fcn shuffling
cwhanse May 15, 2023
7e1be57
update docs
cwhanse May 15, 2023
02bc783
reorder arguments
cwhanse May 16, 2023
fbf3d93
docstring edits
cwhanse May 16, 2023
bdb80ea
add defaults to _integ functions
cwhanse May 16, 2023
ccac4b2
Merge branch 'main' into fix_vf_row_sky_gh1665
cwhanse May 24, 2023
710a5bd
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fix…
cwhanse Jun 7, 2023
667e3f5
Merge branch 'fix_vf_row_sky_gh1665' of https://github.com/mikofski/p…
cwhanse Jun 7, 2023
a11257d
Merge remote-tracking branch 'upstream/main' into pr/1666
kandersolar Jun 23, 2023
b6996e5
fix whatsnew formatting issues
kandersolar Jun 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
12 changes: 12 additions & 0 deletions docs/sphinx/source/reference/bifacial.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,15 @@ Functions for calculating front and back surface irradiance
bifacial.pvfactors.pvfactors_timeseries
bifacial.infinite_sheds.get_irradiance
bifacial.infinite_sheds.get_irradiance_poa

Utility functions for bifacial modeling

.. autosummary::
:toctree: generated/

bifacial.utils.vf_row_sky_2d
bifacial.utils.vf_row_sky_2d_integ
bifacial.utils.vf_row_ground_2d
bifacial.utils.vf_row_ground_2d_integ
bifacial.utils.vf_ground_sky_2d
bifacial.utils.vf_ground_sky_2d_integ
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Shading
.. autosummary::
:toctree: ../generated/

shading.ground_angle
shading.masking_angle
shading.masking_angle_passias
shading.sky_diffuse_passias
15 changes: 15 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.6.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,23 @@ Deprecations

Enhancements
~~~~~~~~~~~~
* Exposes several functions useful for bifacial and shading calculations (:pull:`1666`):
* :py:func:`pvlib.bifacial.utils.bifacial.utils.vf_row_sky_2d1
* :py:func:`pvlib.bifacial.utils.vf_row_sky_2d_integ
* :py:func:`pvlib.bifacial.utils.vf_row_ground_2d
* :py:func:`pvlib.bifacial.utils.vf_row_ground_2d_integ
* :py:func:`pvlib.bifacial.utils.vf_ground_sky_2d
* :py:func:`pvlib.bifacial.utils.vf_ground_sky_2d_integ
* :py:func:`pvlib.shading.ground_angle`


Bug fixes
~~~~~~~~~
* Corrects an error in view factor calculations which are part of
:py:func:`pvlib.bifacial.infinite_sheds.get_irradiance`. The error
affects rear surface irradiance by a few W/m2. As part of the correction,
average view factors are now computed by exact formulas rather than by
numerical integration. (:issue:`1665`, :pull:`1666`)
* `data` can no longer be left unspecified in
:py:meth:`pvlib.modelchain.ModelChain.run_model_from_effective_irradiance`. (:issue:`1713`, :pull:`1720`)

Expand All @@ -38,6 +51,8 @@ Requirements

Contributors
~~~~~~~~~~~~
* Mark Mikofski (:ghuser:`mikofski`)
* Cliff Hansen (:ghuser:`cwhanse`)
* Lakshya Garg (:ghuser:`Lakshyadevelops`)
* Adam R. Jensen (:ghuser:`adamrjensen`)
* Siddharth Kaul (:ghuser:`k10blogger`)
Expand Down
Loading