Add model='gueymard2003' to get_relative_airmass
#1655
Conversation
pvlib/atmosphere.py
Outdated
| * 'pickering2002' - See reference [6] - | ||
| requires apparent sun zenith | ||
| * 'gueymard2003' - See reference [7] - | ||
| requires true sun zenith |
There was a problem hiding this comment.
I've put "true sun zenith" here because I found no mention of refraction correction, "apparent" etc in the reference, but it would be good if a reviewer could determine this with more confidence.
There was a problem hiding this comment.
From Chris Gueymard: "My formulas all use the apparent position--Chris"
There was a problem hiding this comment.
Chris also commented that the default should be a more modern model.
There was a problem hiding this comment.
Chris also commented that the default should be a more modern model.
Does he have specific recommendations?
There was a problem hiding this comment.
Thanks @adriesse for checking!
Updated default: no objection from me, but I think it will have to wait for 0.10.0.
There was a problem hiding this comment.
In a separate issue. I think there could be some general discussion about defaults actually.
There was a problem hiding this comment.
Everything seems to check out 😄
I would like to perhaps add a bit more context because the citation is not very explicit about the equation (the AM model is obscurely hidden in the appendix). Perhaps add the equation number in the citation and consider adding that it is what is used in the REST model.
The book chapter "Clear-Sky Radiation Models and Aerosol Effects" by Gueymard could be considered a good second reference. It provides the equation, lists a few sets of AM coefficients, and provides more context. The relevant part of the book chapter is:
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
|
Thank you @kanderso-nrel 🚀 |
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This is the relative air mass model used in REST and REST2, as well as ASTM G222-21.