Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Caballero et al. spectral factor model #1296
Implement Caballero et al. spectral factor model #1296
Changes from 78 commits
f634e39
b5d7fec
eb948e0
e27c688
03920a6
be39d2e
c9fefeb
125bc16
6a43156
5b890ab
c602a32
97d0e65
0e2d832
8a473ba
397c3e8
7382e36
ed2d4f6
394c4bc
e89248f
25b43df
d9f466e
cdc64fc
422f49f
48474a7
6e9b9d8
43a188c
710cdd3
46519a8
7bc182f
2c36c00
8124675
094d737
f79b8ab
30a6284
38dd836
7e0d7df
3bbf743
38fea4d
92bfc55
5463533
c6cd809
2d338b9
04339ad
c487317
0744b80
6bc7920
ec20bbc
9ebd10e
43a30e5
39c542b
516c059
acaf38d
f937bba
cab0dfa
fd7ec4a
f08b846
ee614f5
2e02b94
4b4e27f
d71455d
e59f7d6
7bf4e52
dc4af99
c09c462
6334d86
72f6cf1
b37cbdb
ff3f660
b4c9dfb
f4ab78f
55ac6a6
d2e7f70
bc353f2
d93b187
5165060
5b16ce3
eb26a2d
4957436
6e10781
4f23ad6
a7b9309
a4560cc
f6d33d4
834fd91
b7d643e
a07c7b6
f9df15b
e1633bf
fea2314
b3b5ee3
1be7250
6a5bbcb
fc37b2d
231129f
ce47bf9
5acd22c
91e6726
0c61d41
7132f5d
ffdd0ba
af41b57
3ad15bb
c314d3c
b56307b
8fa44af
cda92be
c872a3d
3bb26c4
b6a6a08
5b10b84
440ef38
f229255
4ac3a89
dcf7891
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this estimation refer to solar elevation? Airmass calculations are pretty standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adriesse, yes it does. The solar elevation was measured by means of a solar spectral irradiance meter (SolarSIM-D2) from Spectrafy Inc. Then the AM was computed by using the sun’s zenith angle (z). Reference: F. Kasten and A. T. Young, “Revised optical air mass tables and approxi-mation formula,” Appl. Opt., vol. 28, pp. 4735–4738, Nov. 15, 1989.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that your responses might make it into the doc string at some point...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is very good to have a couple of paragraphs explaining the basics here, but unfortunately I find them hard to understand. If you recorded AM, AOD, PW and spectra, then where does smarts come in? I guess I should read the paper, but this text should also be consistent and comprehensible on its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adriesse, the reason for using synthetic spectra, generated through SMARTS2, was to ascertain the ideal polynomial type of the experimental equations related to the AM, AOD and PW parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both of these should be ValueError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand then, if the coefficients are not exactly the ones defined in the script, the ValueError message will appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated