-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Numba usage; numba-fy temperature.fuentes #1098
Conversation
I think this could use another set of eyes -- I'm having some trouble wrapping my head around testing with and without numba and I'm not sure what I'm doing for the SPA tests makes sense. |
warnings.warn("The 'how' parameter is deprecated; numba is now used " | ||
"automatically if it is available.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warnings.warn("The 'how' parameter is deprecated; numba is now used " | |
"automatically if it is available.", | |
warnings.warn("The 'how' parameter is deprecated; numba is now used " | |
"automatically if it is available, otherwise numpy is used.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of numba is beyond me. The spa
interface is better without how
, I think.
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).TODO
s in codenrel_numpy
/nrel_numba
from tutorial notebooks