Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Numba usage; numba-fy temperature.fuentes #1098

Closed
wants to merge 23 commits into from

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Nov 26, 2020

  • Closes reevaluate numba minimum, usage patterns in spa.py #1060
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.
  • Address TODOs in code
  • Update benchmarks to be backwards compatible (e.g. PVLIB_USE_NUMBA)
  • Scrub nrel_numpy/nrel_numba from tutorial notebooks

@kandersolar
Copy link
Member Author

I think this could use another set of eyes -- I'm having some trouble wrapping my head around testing with and without numba and I'm not sure what I'm doing for the SPA tests makes sense.

Comment on lines +1441 to +1442
warnings.warn("The 'how' parameter is deprecated; numba is now used "
"automatically if it is available.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
warnings.warn("The 'how' parameter is deprecated; numba is now used "
"automatically if it is available.",
warnings.warn("The 'how' parameter is deprecated; numba is now used "
"automatically if it is available, otherwise numpy is used.",

Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of numba is beyond me. The spa interface is better without how, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reevaluate numba minimum, usage patterns in spa.py
2 participants