Skip to content

Commit

Permalink
Temperature model parameter translation code (#1463)
Browse files Browse the repository at this point in the history
* First commit to gather feedback on class design.

* Changed set_*/get_* pattern to use_*/to_*

* Add generic_linear() as a separate module temperature function and adjustments to doc strings.

* Add tests.

* Minor test edits.

* One more test to achieve 100% coverage (hopefully).

* Some formatting, docstring development.

* Try to update sphynx.

* Try sphynx again.

* Docstrings nearing completion.

* Docstrings complete.

* One more small name change.

* Fix problems identified in reviews.

* Update whatsnew.

Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov>
  • Loading branch information
adriesse and kandersolar authored Sep 13, 2022
1 parent 543d97a commit 38fc142
Show file tree
Hide file tree
Showing 4 changed files with 512 additions and 1 deletion.
2 changes: 2 additions & 0 deletions docs/sphinx/source/reference/pv_modeling.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ PV temperature models
temperature.noct_sam
temperature.prilliman
pvsystem.PVSystem.get_cell_temperature
temperature.generic_linear
temperature.GenericLinearModel

Temperature Model Parameters
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
8 changes: 7 additions & 1 deletion docs/sphinx/source/whatsnew/v0.9.3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Deprecations

Enhancements
~~~~~~~~~~~~
* New class and function translate module temperature model parameters
:py:func:`~pvlib.temperature.GenericLinearModel`
:py:func:`~pvlib.temperature.generic_linear`
(:issue:`1442`, :pull:`1463`)
* Low resolution altitude lookup map
:py:func:`~pvlib.location.lookup_altitude`
(:issue:`1516`, :pull:`1518`)
Expand Down Expand Up @@ -48,7 +52,9 @@ Contributors
* Anton Driesse (:ghuser:`adriesse`)
* Cliff Hansen (:ghuser:`cwhanse`)
* Kevin Anderson (:ghuser:`kanderso-nrel`)
* Mark Mikofski (:ghuser:`mikofski`)
* Will Holmgren (:ghuser:`wholmgren`)
* Mark Campanelli (:ghuser:`markcampanelli`)
* Adam R. Jensen (:ghuser:`AdamRJensen`)
* Abhishek Parikh (:ghuser:`abhisheksparikh`)
* Taos Transue (:ghuser:`reepoi`)
* Taos Transue (:ghuser:`reepoi`)
Loading

0 comments on commit 38fc142

Please sign in to comment.