fix: Handle multiple connections correctly on dashboard #13
Conversation
|
I had not considered this use case. Out of curiosity, how do you use multiple connections to the same host? How would they be configured differently? |
|
I provide an example in #12 but with github finer-grained tokens you grant access to a specific user/org, giving access to a user does not mean it will show all the repositories they have access to in all their orgs. So I had to create two different tokens one for the org and one for myself. Basically the only difference is the token used for the connection. |
|
That makes sense! |
| @@ -30,7 +30,7 @@ export default function Dashboard() { | |||
| const results = useQueries({ | |||
| queries: config.sections.flatMap(section => { | |||
| return config.connections.map((connection, idx) => ({ | |||
| queryKey: ['pulls', connection.host, section.search], | |||
| queryKey: ['pulls', connection.host, connection.auth, section.search], | |||
There was a problem hiding this comment.
I was considering as an alternative using the connection name that you introduce in #12. But at the same time using the token is a better representation of the identity of the token (e.g., if we switch the names of two connections we should not reuse the cache of the other one).
react-query's built-in memoization was causing connections to the same domain to clobber each other. You would have a race condition on which set of data gets shown and it would show up twice.The goal here is to allow multiple connections to be used and have the sum of all of their PR requests be shown in the dashboard. Since we are already storing the key plain in
localStorageI don't immediately see an issue with utilizing the token as part of the react query key.Though technically it does expose the access token to more libraries. If that's a concern we could hash the token.