-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
8fdb1af
commit 1d4eb34
Showing
1 changed file
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
**IMPORTANT: Please do not create a Pull Request without creating an issue first.** | ||
|
||
Please, go through these steps before you submit a PR: | ||
1. Make sure that your PR is not a duplicate. | ||
2. If not, then make sure that: | ||
|
||
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the `fix/` or `feature/` prefixes. Good examples are: `fix/signin-issue` or `feature/issue-templates`. | ||
|
||
b. You have a descriptive commit message with a short title (first line). | ||
|
||
c. You have only one commit (if not, squash them into one commit). | ||
|
||
d. `npm test` doesn't throw any error. If it does, fix them first and amend your commit (`git commit --amend`). | ||
|
||
3. **After** these steps, you're ready to open a pull request. | ||
|
||
a. Give a descriptive title to your PR. | ||
|
||
b. Describe your changes. | ||
|
||
c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes. | ||
|
||
|
||
*Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.* | ||
|
||
|
||
**IMPORTANT**: Please review the [CONTRIBUTING](../#contribute) section for detailed contributing guidelines. | ||
|
||
**PLEASE REMOVE THIS NOTES BEFORE SUBMITTING** | ||
|
||
|
||
|
||
|
||
|
||
**Fixes** #XX | ||
|
||
Please provide enough information so that others can review your pull request: | ||
|
||
<!-- You can skip this if you're fixing a typo --> | ||
|
||
|
||
Explain the **details** for making this change. What existing problem does the pull request solve? | ||
|
||
<!-- Example: When "Adding a function to do X", explain why it is necessary to have a way to do X. --> | ||
|
||
A picture tells a thousand words: | ||
<!-- Provide a screenshot of npm test command here--> |