Ignore kubectl last applied annotation by default #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3150986 to
d8aa634
Compare
|
/retest |
Quack currently doesn't work properly with custom delimiters, at least not if one is trying to use `kubectl apply` as the input template contains itself (I *think* the main issue is that things get escaped too many times and the `template` package errors out).
d8aa634 to
127a8d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quack currently doesn't work properly with custom delimiters, at least not if one is trying to use
kubectl applyas the input template contains itself (I think the main issue is that things get escaped toomany times and the
templatepackage errors out).This PR makes sure that the path for kubectl's last applied configuration annotation is added to the list of ignored paths (unless it's already present in the list).