Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. The following patches fixes the Emacs
woman
andman
procedures not inheriting the envrc environment.The fix for
woman
is similar to the one done for theinfo-display-manual
procedure, where we needed to flush it's cache.On the other hand, the
man
command was a bit more tricky to solve. The issue was that the completing-read function thatman
uses,Man-completion-table
, needs to inherit the environment. This can be solved advising it withenvrc-propagate-environment
, but since it's invoked from the minibuffer,envrc-mode
mode will be disabled; and the wrapper will not inject the environment. In order to solve it, we need to remove the logic that preventsenvrc-global-mode
to enableenvrc-mode
in the minibuffer.I hope this helps!