Skip to content

Commit

Permalink
(maint) Collapse puppetserver-base Docker directory
Browse files Browse the repository at this point in the history
 - Now that the file to create puppetserver-base is called
   base.Dockerfile, there are no real collisions to avoid.

 - This is the next step towards consolidating to a single Dockerfile
   with multiple build targets
  • Loading branch information
Iristyle committed Dec 19, 2019
1 parent d2156a5 commit d0f99d5
Show file tree
Hide file tree
Showing 16 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ steps:

- powershell: |
. "$(bundle show pupperware)/ci/build.ps1"
Lint-Dockerfile -Name $ENV:CONTAINER_NAME_BASE -Path "docker/${ENV:CONTAINER_NAME_BASE}/base.Dockerfile" -Ignore ($ENV:LINT_IGNORES -split ' ')
Lint-Dockerfile -Name $ENV:CONTAINER_NAME_BASE -Path "docker/puppetserver/base.Dockerfile" -Ignore ($ENV:LINT_IGNORES -split ' ')
displayName: Lint $(CONTAINER_NAME_BASE) Dockerfile
timeoutInMinutes: 1
name: lint_base_dockerfile
Expand All @@ -63,7 +63,7 @@ steps:

- powershell: |
. "$(bundle show pupperware)/ci/build.ps1"
Build-Container -Name $ENV:CONTAINER_NAME_BASE -Dockerfile "docker/${ENV:CONTAINER_NAME_BASE}/base.Dockerfile" -Namespace $ENV:NAMESPACE -AdditionalOptions ($ENV:BUILD_OPTIONS -split ' ')
Build-Container -Name $ENV:CONTAINER_NAME_BASE -Dockerfile "docker/puppetserver/base.Dockerfile" -Namespace $ENV:NAMESPACE -AdditionalOptions ($ENV:BUILD_OPTIONS -split ' ')
displayName: Build $(CONTAINER_NAME_BASE) Container
timeoutInMinutes: 5
name: build_base_container
Expand Down
8 changes: 4 additions & 4 deletions docker/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ prep:

lint:
ifeq ($(hadolint_available),0)
@$(hadolint_command) puppetserver-base/base.Dockerfile
@$(hadolint_command) puppetserver/base.Dockerfile
@$(hadolint_command) puppetserver/$(dockerfile)
else
@docker pull $(hadolint_container)
@docker run --rm -v $(PWD)/puppetserver/$(dockerfile):/Dockerfile \
-i $(hadolint_container) $(hadolint_command) Dockerfile
@docker run --rm -v $(PWD)/puppetserver-base/base.Dockerfile:/Dockerfile \
@docker run --rm -v $(PWD)/puppetserver/base.Dockerfile:/Dockerfile \
-i $(hadolint_container) $(hadolint_command) Dockerfile
endif

Expand All @@ -46,8 +46,8 @@ build: prep
--build-arg build_date=$(build_date) \
--build-arg version=$(VERSION) \
--build-arg pupperware_analytics_stream=$(PUPPERWARE_ANALYTICS_STREAM) \
--file puppetserver-base/base.Dockerfile \
--tag $(NAMESPACE)/puppetserver-base:$(VERSION) puppetserver-base \
--file puppetserver/base.Dockerfile \
--tag $(NAMESPACE)/puppetserver-base:$(VERSION) puppetserver \
${DOCKER_BUILD_FLAGS}
docker build \
--build-arg namespace=$(NAMESPACE) \
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit d0f99d5

Please sign in to comment.