Use Rubocop's Github Actions formatter if possible

[ekohl]

Rubocop 1.2 introduced a Github Actions formatter which creates annotations. This change uses it when it runs on Github Actions and Rubocop is new enough.

Currently a draft since I haven't tried this yet.

[codecov-commenter]

Codecov Report

Merging #340 (96dcd84) into main (cbad6f4) will decrease coverage by 0.42%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   43.28%   42.85%   -0.43%     
==========================================
  Files          11       10       -1     
  Lines         841      770      -71     
==========================================
- Hits          364      330      -34     
+ Misses        477      440      -37     

Impacted Files	Coverage Δ
lib/puppetlabs_spec_helper/puppet_spec_helper.rb	65.51% <ø> (ø)
lib/puppetlabs_spec_helper/tasks/fixtures.rb	38.36% <ø> (ø)
lib/puppetlabs_spec_helper/rake_tasks.rb	42.50% <63.15%> (+1.03%)	⬆️
...bs_spec_helper/puppetlabs_spec/puppet_internals.rb	92.50% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b2473...96dcd84. Read the comment docs.

[da-ar]

Thanks for the PR it looks to work well.
It appears that if you run rubocop within a matrix it will annotate the same error for each item in the matrix.

[ekohl]

Thanks for checking that. I don't think it would affect us really (Voxpupuli) since we only run Rubocop once in a validation step before we run the actual tests: https://github.com/voxpupuli/modulesync_config/blob/5e2741cfc0472da80146c50782abef3c2b567a6e/moduleroot/.github/workflows/ci.yml.erb#L6-L29. Is it a concern for others that we need to solve? I'd recommend everyone to only run validation steps once, just to save CI resources.

[ekohl]

So I opened puppetlabs/pdk-templates#441 to start the discussion.

[da-ar]

@ekohl currently waiting for puppetlabs/pdk-templates#441 to progress. If it goes in, then I'm happy for this to be merged also.

[da-ar]

@ekohl puppetlabs/pdk-templates#441 has been merged so If you are happy to take this PR out of draft i'll get it merged. TY.

[bastelfreak]

@da-ar awesome, thanks for merging. Would it be possible to publish a new release soon?

[da-ar]

@da-ar awesome, thanks for merging. Would it be possible to publish a new release soon?

Sorry for the delay, I was waiting for push rights to Ruby Gems.