Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing wrong type for unless execs #592

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

LukasAud
Copy link
Contributor

Prior to this commit, as part of codebase hardening, unless commands were wrapped in nested arrays so as to follow with proper convention. However, a bug is found where unless commands containing a pipe | will not work when broken down, nor when placed in a nested array.

This commit aims to revert some changes from the original codebase hardening to address the failing conditionals.

Prior to this commit, as part of codebase hardening, unless commands
were wrapped in nested arrays so as to follow with proper convention.
However, a bug is found where unless commands containing a pipe | will
not work when broken down, nor when placed in a nested array.

This commit aims to revert some changes from the original codebase
hardening to address the failing conditionals.
@LukasAud LukasAud requested a review from a team as a code owner November 29, 2022 10:46
@puppet-community-rangefinder
Copy link

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

kubernetes::kubeadm_init is a type

that may have no external impact to Forge modules.

kubernetes::kubeadm_join is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@BaronMsk
Copy link
Contributor

We still need to fix the test code

@BaronMsk
Copy link
Contributor

BaronMsk commented Dec 1, 2022

Forgot about SWAP!

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jordanbreen28 jordanbreen28 merged commit 7238ba0 into main Dec 5, 2022
@jordanbreen28 jordanbreen28 deleted the maint-addressing_unless_typos branch December 5, 2022 13:00
@chelnak chelnak changed the title (MAINT) Addressing wrong type for unless execs Addressing wrong type for unless execs Dec 5, 2022
@LukasAud LukasAud mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants