Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new parameter node_extra_taints #586

Merged
merged 3 commits into from
Jan 27, 2023
Merged

add new parameter node_extra_taints #586

merged 3 commits into from
Jan 27, 2023

Conversation

BaronMsk
Copy link
Contributor

@BaronMsk BaronMsk commented Nov 7, 2022 •
edited
Loading

parameter node_extra_taints Additional taints for new instaled nodes.

@BaronMsk BaronMsk requested a review from a team as a code owner November 7, 2022 09:27
@puppet-community-rangefinder
Copy link

kubernetes::config::worker is a class

that may have no external impact to Forge modules.

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ybolotnikov
ybolotnikov previously approved these changes Nov 7, 2022
View reviewed changes
@GSPatton
Copy link
Contributor

GSPatton commented Nov 7, 2022

Hi @BaronMsk. Could you add a description to this PR? Also, this change would need additional tests. Could you add some?

Thanks

@BaronMsk BaronMsk force-pushed the node_extra_taints branch 3 times, most recently from 2ba814b to 07e9b3d Compare November 7, 2022 15:29
@BaronMsk
Copy link
Contributor Author

BaronMsk commented Nov 7, 2022

@GSPatton i added some tests

@jordanbreen28
Copy link
Contributor

Hi @BaronMsk - thanks for all your work on this one.
This looks good to merge now, so can you rebase with main and we can proceed.

jordanbreen28
jordanbreen28 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 jordanbreen28 merged commit 74dec8d into puppetlabs:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud left review comments

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

@ybolotnikov ybolotnikov ybolotnikov left review comments

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BaronMsk @GSPatton @jordanbreen28 @ybolotnikov @LukasAud @ia-content