Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to guess docker_version (#564) #565

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

deric
Copy link
Collaborator

@deric deric commented Jul 19, 2022

This PR should fix rspec tests that are currently failing (incorrect expectations).

Guessing docker_version for RedHat and Debian systems isn't very helpful.

@deric deric requested a review from a team as a code owner July 19, 2022 13:19
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@danifr
Copy link
Contributor

danifr commented Jul 26, 2022

Hi @chelnak, can you or someone from your team please review this PR?

It looks like it will fix the broken spec tests that is blocking other PR. Thanks a lot

@chelnak
Copy link
Contributor

chelnak commented Jul 26, 2022

ping @puppetlabs/modules

@pmcmaw pmcmaw self-assigned this Jul 26, 2022
@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 26, 2022

Thanks for this PR @deric and thank you @danifr for highlighting it.
Changes LGTM.

@pmcmaw pmcmaw merged commit 43fa187 into puppetlabs:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants