Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CLOUD-1640) Remove package resource for kubernetes-cni #53

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

abottchen
Copy link
Contributor

Prior to this commit, kubernetes-cni was installed as a separate
package resource. Regardless of the version specified, yum would
detect the kubelet prerequisite, which would automatically pull the
latest version. Since we install kubelet just a few lines later,
and that installation will automatically pull the needed version
of kubernetes-cni, this package resource appears to not be needed,
and causes the incorrect version to get installed.

Removing it resolved the errors since the needed dependencies will be
pulled in when kubelet is installed.

would automatically pull in the most recent version

Prior to this commit, kubernetes-cni was installed as a separate
package resource.  Regardless of the version specified, yum would
detect the kubelet prerequisite, which would automatically pull the
latest version.  Since we install kubelet just a few lines later,
and that installation will automatically pull the needed version
of kubernetes-cni, this package resource appears to not be needed,
and causes the incorrect version to get installed.

Removing it resolved the errors since the needed dependencies will be
pulled in when kubelet is installed.

would automatically pull in the most recent version
@abottchen abottchen force-pushed the cloud-1640-package-mismatch branch from afdeb17 to 89d2b8a Compare January 30, 2018 19:52
@scotty-c
Copy link
Contributor

LGTM

@scotty-c scotty-c merged commit fe5d286 into puppetlabs:master Jan 30, 2018
scotty-c added a commit that referenced this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants