Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update criSocket to avoid deprecation warnings #475

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

treydock
Copy link
Contributor

With Kubernetes 1.19.4 this is message I get when I restart kubelet:

Jan 21 14:37:33 kubecontroller-dev kubelet: W0121 14:37:33.169859   53934 util_unix.go:103] Using "/run/containerd/containerd.sock" as endpoint is deprecated, please consider using full url format "unix:///run/containerd/containerd.sock".

@treydock treydock requested a review from a team as a code owner January 21, 2021 19:46
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #475 (5cb0fb4) into main (fbae230) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #475   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines         44      44           
=====================================
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbae230...5cb0fb4. Read the comment docs.

@daianamezdrea
Copy link
Contributor

daianamezdrea commented Feb 15, 2021

Hi @treydock , the PR looks good, do you mind if you do the same change for all the templates in order to maintain the consistency ? Thank you

@treydock
Copy link
Contributor Author

@daianamezdrea I've updated all the templates with criSocket defined to use the proper unix socket path

@daianamezdrea
Copy link
Contributor

Great, thank you so much @treydock !

@daianamezdrea daianamezdrea merged commit e5d338e into puppetlabs:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants