Allow setting metricsBindAddress #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 2 2
Lines 44 44
=====================================
Misses 44 44Continue to review full report at Codecov.
|
|
@TJM Thanks for submitting the PR. Changes look good. Could you please add a unit test to verify the changes. Thank you. |
|
I am not great at unit tests (never really saw the point of testing the functionality of the language), but I can try. :-/ |
|
@TJM thanks for the quick response. Running the changes on Adhoc pipeline. Will merge them as soon as the runs finish successfully. |
|
|
sheenaajay
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the ability to override the metricsBindAddress, which is currently hard coded to 127.0.0.1. This does not change the default, but allows it to be set.
Tommy