Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add_support_1.16 #351

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Add_support_1.16 #351

merged 2 commits into from
Nov 8, 2019

Conversation

BaronMsk
Copy link
Contributor

@BaronMsk BaronMsk commented Nov 6, 2019

No description provided.

@BaronMsk BaronMsk requested a review from a team as a code owner November 6, 2019 10:12
@BaronMsk BaronMsk force-pushed the feature_controlpanel branch from ad07533 to ae93ba0 Compare November 7, 2019 07:17
@lionce
Copy link
Contributor

lionce commented Nov 8, 2019

Hello @BaronMsk ,

Would you please rebase your PR with the latest changes from master? Thanks

Cheers!

@BaronMsk BaronMsk force-pushed the feature_controlpanel branch from ae93ba0 to e20846c Compare November 8, 2019 11:28
@BaronMsk
Copy link
Contributor Author

BaronMsk commented Nov 8, 2019

Hello @lionce, Done

@carabasdaniel carabasdaniel merged commit 197925d into puppetlabs:master Nov 8, 2019
@nickperry
Copy link
Contributor

nickperry commented Nov 25, 2019 •
edited
Loading

Wouldn't

  $config_version = $kubernetes_version ? {
    /1.1(0|1)/ => 'v1alpha1',
    /1.12/     => 'v1alpha3',
    /1.1(3|4|5)/ => 'v1beta1',
    default    => 'v1beta2',
  }

have been a better implementation?

@BaronMsk
Copy link
Contributor Author

@nickperry not a bad...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BaronMsk @lionce @nickperry @carabasdaniel @sheenaajay