Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Updated .sync.yml #150

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Aug 16, 2018

Update .sync.yml to remove duplicate dependency declarations
and switched to using the puppet-module-gems.
Also includes subsequent PDK template changes.

@bmjen
Copy link
Contributor Author

bmjen commented Aug 16, 2018

/cc @sheenaajay

@sheenaajay
Copy link
Contributor

@bmjen Thanks Bryan. Looks good. Now we dont have to manually edit the Gemfile and travis.yml file.pdk update can be done for subsequent releases.
Could you please add the exclude directories to the .rubocop.yml file since the rubocop validation is failing.

Update .sync.yml to remove duplicate dependency declarations
and switched to using the puppet-module-gems.
Also includes subsequent PDK template changes.
@bmjen
Copy link
Contributor Author

bmjen commented Aug 17, 2018

I've updated the .sync.yml to override the template defaults and you now don't have to manually reconfigure things.

/cc @sheenaajay @HelenCampbell

@sheenaajay sheenaajay merged commit 9fa74b5 into puppetlabs:master Aug 19, 2018
@sheenaajay
Copy link
Contributor

@bmjen +1 thank you

@bmjen bmjen deleted the update-sync-yml branch August 20, 2018 18:06
@davejrt davejrt added this to the 3.0.0 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants